Log warning when secret backend kwargs is invalid #26580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help debugging a bit.
potiuk
approved these changes
Sep 22, 2022
|
Merging. The failed tests are fixed in main |
jedcunningham
pushed a commit
that referenced
this pull request
Sep 26, 2022
This should help debugging a bit. (cherry picked from commit 2060ed4)
jedcunningham
pushed a commit
that referenced
this pull request
Sep 27, 2022
This should help debugging a bit. (cherry picked from commit 2060ed4)
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just spent a good chunk of an hour debugging why the kwargs are not applied. This should help it a bit in the future.