Fix grid view log try numbers #26556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:UI
|
cc: @pierrejeambrun |
| @@ -99,12 +98,13 @@ const Logs = ({ | |||
| tryNumber, | |||
| }: Props) => { | |||
| const [internalIndexes, externalIndexes] = getLinkIndexes(tryNumber); | |||
| const [selectedAttempt, setSelectedAttempt] = useState(1); | |||
| const [manuallySelectedAttempt, setSelectedAttempt] = useState<number | undefined>(); | |||
There was a problem hiding this comment.
nit: Should we rename also the setter ? (Not a big fan of having the state and its setter with different names)
There was a problem hiding this comment.
I decided to remove all use of "attempt" and use selectedTryNumber and taskTryNumber instead.
pierrejeambrun
approved these changes
Sep 21, 2022
dstandish
approved these changes
Sep 21, 2022
jedcunningham
pushed a commit
that referenced
this pull request
Sep 26, 2022
* redo how try numbers are displayed in grid view logs * rename attempt -> tryNumber (cherry picked from commit 6a69ad0)
jedcunningham
pushed a commit
that referenced
this pull request
Sep 27, 2022
* redo how try numbers are displayed in grid view logs * rename attempt -> tryNumber (cherry picked from commit 6a69ad0)
22 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The try numbers shown in the grid view logs were showing an extra count and just not consistent with how the regular logs page works.
Fixes #26194 (comment)
Other fixes:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.