Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix WSGI root app #26549

Merged
merged 2 commits into from Sep 22, 2022
Merged

fix WSGI root app #26549

merged 2 commits into from Sep 22, 2022

Conversation

sprohaska
Copy link
Contributor

The start_response() callable expects a string in argument status. See https://peps.python.org/pep-0333/#the-start-response-callable.

Signed-off-by: Steffen Prohaska prohaska@zib.de

The `start_response()` callable expects a string in argument `status`.
See <https://peps.python.org/pep-0333/#the-start-response-callable>.

Signed-off-by: Steffen Prohaska <prohaska@zib.de>
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Sep 21, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 21, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk added this to the Airflow 2.4.1 milestone Sep 21, 2022
@ashb
Copy link
Member

ashb commented Sep 21, 2022

Is it worth adding a test for this?

@uranusjr
Copy link
Member

Unit test is probably not worth it since it’d be mostly just testing the protocol. Type hints would be useful though since the stdlib wsgi lib is fully typed.

This provides typing guardrails for the middleware callable.
@potiuk
Copy link
Member

potiuk commented Sep 22, 2022

Unit test is probably not worth it since it’d be mostly just testing the protocol. Type hints would be useful though since the stdlib wsgi lib is fully typed.

Agree.

@potiuk potiuk merged commit 39f99ec into apache:main Sep 22, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 22, 2022

Awesome work, congrats on your first merged pull request!

@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Sep 23, 2022
jedcunningham pushed a commit that referenced this pull request Sep 23, 2022
* fix WSGI root app

The `start_response()` callable expects a string in argument `status`.
See <https://peps.python.org/pep-0333/#the-start-response-callable>.

Signed-off-by: Steffen Prohaska <prohaska@zib.de>

* Better type WSGI middleware

This provides typing guardrails for the middleware callable.

Signed-off-by: Steffen Prohaska <prohaska@zib.de>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
(cherry picked from commit 39f99ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants