New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix WSGI root app #26549
fix WSGI root app #26549
Conversation
The `start_response()` callable expects a string in argument `status`. See <https://peps.python.org/pep-0333/#the-start-response-callable>. Signed-off-by: Steffen Prohaska <prohaska@zib.de>
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Is it worth adding a test for this? |
Unit test is probably not worth it since it’d be mostly just testing the protocol. Type hints would be useful though since the stdlib wsgi lib is fully typed. |
This provides typing guardrails for the middleware callable.
Agree. |
Awesome work, congrats on your first merged pull request! |
* fix WSGI root app The `start_response()` callable expects a string in argument `status`. See <https://peps.python.org/pep-0333/#the-start-response-callable>. Signed-off-by: Steffen Prohaska <prohaska@zib.de> * Better type WSGI middleware This provides typing guardrails for the middleware callable. Signed-off-by: Steffen Prohaska <prohaska@zib.de> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 39f99ec)
The
start_response()
callable expects a string in argumentstatus
. See https://peps.python.org/pep-0333/#the-start-response-callable.Signed-off-by: Steffen Prohaska prohaska@zib.de