Fix proper joining of the path for logs retrieved from celery workers #26493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change apache#26377 "fixed" the way how logs were retrieved from Celery, but it - unfortunately broke the retrieval eventually. This PR should fix it. Fixes: apache#26492
potiuk
force-pushed
the
fix-log-retrieval-for-celery-workers
branch
from
824ca74
to
cbdf03b
Compare
2 tasks
ephraimbuddy
approved these changes
Sep 19, 2022
jedcunningham
approved these changes
Sep 19, 2022
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 19, 2022
…apache#26493) The change apache#26377 "fixed" the way how logs were retrieved from Celery, but it - unfortunately broke the retrieval eventually. This PR should fix it. Fixes: apache#26492 (cherry picked from commit 52560b8)
|
Should we add a unit test to prevent regression? |
Yeah. I thought of that. I will add it. |
ashb
added
type:bug-fix
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 22, 2022
Added unit test to apache#26493
|
Added Unit test in #26603 not "super" valuable, but better than nothing (and this - essentially where it failed) |
potiuk
added a commit
that referenced
this pull request
Sep 22, 2022
* Add unit test for log retrieval url Added unit test to #26493
jedcunningham
pushed a commit
that referenced
this pull request
Sep 23, 2022
jedcunningham
pushed a commit
that referenced
this pull request
Sep 23, 2022
|
Thanks @potiuk I am experiencing the same problem with my CeleryExecutor setup and it is resolved by applying the trailing slash as in this PR. :) |
|
Cool. 2.4.1 will fix it permanently :) |
2 tasks
22 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change #26337 "fixed" the way how logs were retrieved from Celery, but it - unfortunately broke the retrieval eventually.
This PR should fix it.
Fixes: #26492
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.