DAG Deps extends base_template
#26439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DAG Deps page should extend `base_template` instead of Airflow's main template (which is the default `base_template`). This is consistent with all other pages and allows for proper UI customization.
jedcunningham
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
kaxil
approved these changes
Sep 16, 2022
jedcunningham
added a commit
that referenced
this pull request
Sep 23, 2022
The DAG Deps page should extend `base_template` instead of Airflow's main template (which is the default `base_template`). This is consistent with all other pages and allows for proper UI customization. (cherry picked from commit 9925bbd)
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DAG Deps page should extend
base_templateinstead of Airflow's main template (which is the defaultbase_template). This is consistent with all other pages and allows for proper UI customization.