template rendering issue in passing templates_dict param using task decorator #26390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:core-operators
Bowrna
force-pushed
the
file_rendering_task_decorator
branch
2 times, most recently
from
e0555d9
to
0846183
Compare
kaxil
reviewed
Sep 14, 2022
Comment on lines
+38
to
+39
| template_fields: Sequence[str] = ('templates_dict', 'op_args', 'op_kwargs') | ||
| template_fields_renderers = {"templates_dict": "json", "op_args": "py", "op_kwargs": "py"} |
There was a problem hiding this comment.
Can you add a test for the case you are mentioning
Bowrna
force-pushed
the
file_rendering_task_decorator
branch
3 times, most recently
from
976dd52
to
f9fd527
Compare
Bowrna
force-pushed
the
file_rendering_task_decorator
branch
3 times, most recently
from
a3429c5
to
a138bf9
Compare
Bowrna
force-pushed
the
file_rendering_task_decorator
branch
2 times, most recently
from
63ced93
to
170417a
Compare
Bowrna
force-pushed
the
file_rendering_task_decorator
branch
from
170417a
to
88f6bf1
Compare
potiuk
approved these changes
Sep 19, 2022
|
@kaxil I will add the tests for this PR as a separate PR. This PR got merged before adding the test |
jedcunningham
pushed a commit
that referenced
this pull request
Sep 23, 2022
(cherry picked from commit 4bf0cb9)
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #22072
Fix for the following issue:
The filenames inside the templates_dict is rendered in PythonOperator while it doesn't get rendered when passed as parameter using
@taskdecorator.This PR fixes the issue and updates the documentation and adds in the system test.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.