New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trigger rule tooltip #26043
Add trigger rule tooltip #26043
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There are a few linting issues. I'd run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's double check everywhere we call tiTooltip
. I think we'll get an error in at least gantt.js, maybe other spots.
Also, care to include a screenshot of the updated tooltip so other reviewers can see what the UI change is?
|
Accomodates the additional argument for the tiTooltip object
Change condition for determining if task.trigger_rule is present Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thanks for putting up with all my comments.
This was my first ever open source contribution so I really appreciated the comments. Thanks for making the process enjoyable! |
Awesome work, congrats on your first merged pull request! |
closes: #21201
related: #19939
This adds the Trigger Rule to the tooltip of operators in the graph view. It provides more detail about the relationships between up and downstream tasks in a DAG.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.