Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger rule tooltip #26043

Merged
merged 7 commits into from Aug 31, 2022
Merged

Add trigger rule tooltip #26043

merged 7 commits into from Aug 31, 2022

Conversation

adamfrly
Copy link
Contributor

closes: #21201
related: #19939

This adds the Trigger Rule to the tooltip of operators in the graph view. It provides more detail about the relationships between up and downstream tasks in a DAG.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Aug 29, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 29, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@bbovenzi
Copy link
Contributor

There are a few linting issues. I'd run yarn && yarn lint in the /airflow/www directory. Otherwise, looking good.

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's double check everywhere we call tiTooltip. I think we'll get an error in at least gantt.js, maybe other spots.

Also, care to include a screenshot of the updated tooltip so other reviewers can see what the UI change is?

@adamfrly
Copy link
Contributor Author

Attached is a screenshot of the change to the Graph view tooltip. Note that "Trigger Rule" has been added just below the Operator indicator.
tooltip_UI_change

@adamfrly
Copy link
Contributor Author

Let's double check everywhere we call tiTooltip. I think we'll get an error in at least gantt.js, maybe other spots.

Also, care to include a screenshot of the updated tooltip so other reviewers can see what the UI change is?

tiTooltip is used in gantt.js, graph.js, and dags.js. In gantt.js null was passed as the second argument to tiTooltip so that arguments are now passed properly. In the other two files however, the extra task argument doesn't look like it will cause any problems

@adamfrly adamfrly requested review from bbovenzi and removed request for ryanahamilton and ashb August 31, 2022 16:49
Change condition for determining if task.trigger_rule is present

Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for putting up with all my comments.

@adamfrly
Copy link
Contributor Author

This was my first ever open source contribution so I really appreciated the comments. Thanks for making the process enjoyable!

@bbovenzi bbovenzi merged commit f94176b into apache:main Aug 31, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 31, 2022

Awesome work, congrats on your first merged pull request!

@adamfrly adamfrly deleted the add-trigger-rule-tooltip branch August 31, 2022 19:57
@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Sep 13, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Trigger Rule Display to Graph View
3 participants