Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conf parameter to CLI for airflow dags test #25900

Merged

Conversation

clellmann
Copy link
Contributor

@clellmann clellmann commented Aug 23, 2022


This PR adds a feature so that it's possible to pass a DAG run conf via the CLI for debugging DAGs wit "airflow dags test". This closes the gap, that templated operator fields using this DAG run config can also be debugged.

closes: #25671

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 23, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@clellmann clellmann force-pushed the feature/pass-dag-run-conf-via-airflow-dags-test branch from 86c4948 to be5f504 Compare August 23, 2022 10:10
@potiuk
Copy link
Member

potiuk commented Aug 23, 2022

You likely need to add a case in cli unit tests as well.

@clellmann
Copy link
Contributor Author

You likely need to add a case in cli unit tests as well.

Thanks for the hint. Will provide this too.

@clellmann clellmann force-pushed the feature/pass-dag-run-conf-via-airflow-dags-test branch from 6d2651b to b308b5a Compare August 23, 2022 11:49
@clellmann
Copy link
Contributor Author

Hi, I need help regarding the failing git checkout in the pipeline. Can you restart the pipeline or what is the issue?

@potiuk
Copy link
Member

potiuk commented Aug 23, 2022

restarted. Transient issue. In the futute - you can simply commit --amend and --force push to re-trigger the build

@clellmann clellmann force-pushed the feature/pass-dag-run-conf-via-airflow-dags-test branch from b308b5a to eb99d02 Compare August 23, 2022 13:58
@clellmann
Copy link
Contributor Author

I need a review here please as everything is green now :)

@potiuk potiuk force-pushed the feature/pass-dag-run-conf-via-airflow-dags-test branch from eb99d02 to 3b48dfa Compare August 25, 2022 11:56
@clellmann clellmann force-pushed the feature/pass-dag-run-conf-via-airflow-dags-test branch 2 times, most recently from 8919a8f to adf02c7 Compare August 26, 2022 14:26
@clellmann clellmann force-pushed the feature/pass-dag-run-conf-via-airflow-dags-test branch from adf02c7 to ae5d753 Compare August 29, 2022 06:46
@uranusjr uranusjr merged commit bcc2fe2 into apache:main Aug 29, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 29, 2022

Awesome work, congrats on your first merged pull request!

@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Sep 13, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

airflow dags test command with run confs
5 participants