Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option of sending DAG parser logs to stdout. #25754

Merged
merged 4 commits into from Sep 7, 2022

Conversation

jhtimmins
Copy link
Contributor

This is a continuation of #25528, with the addition of tests.

There were issues getting #25528 to run locally, so I duplicated the PR.

@boring-cyborg boring-cyborg bot added the area:Scheduler Scheduler or dag parsing Issues label Aug 17, 2022
@jhtimmins
Copy link
Contributor Author

@kaxil this includes the tests you requested for the linked PR

@uranusjr can you take another look at this PR? It's the same as the linked one, with the addition of tests.

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the linter error needs to be fixed.

@jhtimmins
Copy link
Contributor Author

@ashb @uranusjr looks like An unrelated file in the same test directory keeps failing on MSSQL2017. Is it well known that this is a problematic test environment? Unsure if I should disregard.

https://github.com/apache/airflow/runs/7892800524?check_suite_focus=true

@potiuk
Copy link
Member

potiuk commented Aug 26, 2022

Restarting is easiest way to try @jhtimmins. I did it now, but you should be able to do it when things fail as well.

@kaxil kaxil force-pushed the send-parser-logs-to-stdout-v2 branch from 2161fb3 to c0cf86e Compare September 6, 2022 16:28
@uranusjr
Copy link
Member

uranusjr commented Sep 6, 2022

Test failures not related, it’s introduced into main by another PR.

@jhtimmins jhtimmins force-pushed the send-parser-logs-to-stdout-v2 branch 2 times, most recently from 692e631 to 42e09df Compare September 7, 2022 08:20
@jhtimmins
Copy link
Contributor Author

@ashb
Copy link
Member

ashb commented Sep 7, 2022

@uranusjr are you referring to this error? https://github.com/apache/airflow/runs/8220641637?check_suite_focus=true#step:13:3875

No that is something else (but likely not this PR) https://github.com/apache/airflow/runs/8215672242?check_suite_focus=true#step:9:12013 is the error he's talking about I think

@jhtimmins jhtimmins merged commit dc94afd into apache:main Sep 7, 2022
@jhtimmins jhtimmins deleted the send-parser-logs-to-stdout-v2 branch September 7, 2022 10:06
@eladkal eladkal added this to the Airflow 2.4.0 milestone Sep 7, 2022
@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler Scheduler or dag parsing Issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants