Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing to task decorator in docs from classic operator use #25711

Merged
merged 2 commits into from Sep 16, 2022

Conversation

Bowrna
Copy link
Contributor

@Bowrna Bowrna commented Aug 14, 2022

related: #25319

This contains a fix for docs under the concepts folder mentioned in the above issue. Made changes only to the code part and still relevant doc changes have to be updated.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Bowrna Bowrna force-pushed the task-decorator-in-docs branch 2 times, most recently from ab2adb3 to 322f474 Compare August 23, 2022 16:29
@Bowrna Bowrna force-pushed the task-decorator-in-docs branch 4 times, most recently from 08248eb to f1e9c39 Compare September 2, 2022 08:39
@Bowrna Bowrna marked this pull request as ready for review September 2, 2022 08:40
@Bowrna Bowrna force-pushed the task-decorator-in-docs branch 5 times, most recently from 32ccbb0 to 87c3765 Compare September 2, 2022 18:04
@Bowrna
Copy link
Contributor Author

Bowrna commented Sep 5, 2022

@uranusjr Is there any more place where I can improve?

Bowrna and others added 2 commits September 13, 2022 14:32
As suggested in commented by uranusjr

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@Bowrna
Copy link
Contributor Author

Bowrna commented Sep 13, 2022

@uranusjr I have left some questions to clarify in this PR. Can you help me with them when you have time? thanks

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@potiuk potiuk merged commit 3d76733 into apache:main Sep 16, 2022
@eladkal eladkal added this to the Airflow 2.4.1 milestone Sep 16, 2022
@eladkal eladkal added the type:doc-only Changelog: Doc Only label Sep 16, 2022
jedcunningham pushed a commit that referenced this pull request Sep 23, 2022
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
(cherry picked from commit 3d76733)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants