-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Fix mapped sensor with reschedule mode #25594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
77cbf40
to
71162ea
Compare
3f4abac
to
32ed0fc
Compare
Hmm, I am not sure putting ReadyToReschedule in BaseOperator is a good idea. Why is this needed though? MappedOperator reads |
32ed0fc
to
10ba710
Compare
Figured and fixed the |
10ba710
to
a1e7138
Compare
ad00058
to
5a0e1cc
Compare
We need some more tests on
|
There are two issues with mapped sensor with `reschedule` mode. First, the reschedule table is being populated with a default map_index of -1 even when the map_index is not -1. Secondly, MappedOperator does not have the `ReadyToReschedule` dependency. This PR is an attempt to fix this
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
bc32baf
to
11aca93
Compare
There are two issues with mapped sensor with `reschedule` mode. First, the reschedule table is being populated with a default map_index of -1 even when the map_index is not -1. Secondly, MappedOperator does not have the `ReadyToReschedule` dependency. This PR is an attempt to fix this Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 5f3733e)
There are two issues with mapped sensor with
reschedule
mode. First, the reschedule table is being populated with a default map_index of -1 even when the map_index is not -1. Secondly, MappedOperator does not have theReadyToReschedule
dependency.This PR is an attempt to fix this
closes: #25095