Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalidateQueries call #25097

Merged
merged 1 commit into from Jul 15, 2022

Conversation

pierrejeambrun
Copy link
Member

Update the call to invalidateQueries

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 15, 2022
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should turn these keys into reusable functions so we don't get simple mistake like this in the future.

@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Jul 15, 2022

We could do that, for now switching to typescript will help, for instance in this case we have an error saying we are passing too many arguments to the function.

If we did the same with 3 or less params most chances are the types are not compatible, and ts would also help here:
image

@bbovenzi bbovenzi merged commit b4e9c67 into apache:main Jul 15, 2022
@pierrejeambrun pierrejeambrun deleted the fix-invalidate-query-call branch July 15, 2022 17:04
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Aug 12, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.4 milestone Aug 12, 2022
ephraimbuddy pushed a commit that referenced this pull request Aug 15, 2022
(cherry picked from commit b4e9c67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants