Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set default task group in dag.add_task method #25000

Merged
merged 1 commit into from Aug 5, 2022
Merged

set default task group in dag.add_task method #25000

merged 1 commit into from Aug 5, 2022

Conversation

blcksrx
Copy link
Contributor

@blcksrx blcksrx commented Jul 12, 2022 •
edited by josh-fell

Closes: #24996

@potiuk
Copy link
Member

potiuk commented Jul 12, 2022

Tests need fixing and likely new tests for this specific case should be added

@blcksrx blcksrx force-pushed the AIRFLOW-24996 branch 5 times, most recently from d007ab1 to a0a4a5c Compare July 26, 2022 08:32
uranusjr
uranusjr reviewed Jul 26, 2022
View reviewed changes
tests/models/test_dag.py Outdated Show resolved Hide resolved
@uranusjr
Copy link
Member

This has a weird side effect that the task is identified in the DAG under a different task_id than the task_id attribute set on that task object. I don’t think I am particularly fond with it.

@blcksrx
Copy link
Contributor Author

blcksrx commented Jul 26, 2022

Yeah Indeed, Im working on it

@ashb ashb requested a review from uranusjr July 26, 2022 14:32
@uranusjr
Copy link
Member

When you fix the task_id issue, please also add a line in the test to ensure task_with_task_group.task_id is correctly prefixed by the task group ID.

set default task group in dag.add_task method
ffb40ab 
Signed-off-by: Hossein Torabi <blcksrx@gmail.com>
@blcksrx blcksrx requested a review from uranusjr July 27, 2022 11:39
@blcksrx
Copy link
Contributor Author

blcksrx commented Aug 1, 2022

When you fix the task_id issue, please also add a line in the test to ensure task_with_task_group.task_id is correctly prefixed by the task group ID.

@uranusjr done!

@potiuk potiuk merged commit ce0a6e5 into apache:main Aug 5, 2022
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Aug 15, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.4 milestone Aug 15, 2022
ephraimbuddy pushed a commit that referenced this pull request Aug 15, 2022
@ephraimbuddy
set default task group in dag.add_task method (#25000)
dffcb5d 
Signed-off-by: Hossein Torabi <blcksrx@gmail.com>
(cherry picked from commit ce0a6e5)
@ephraimbuddy ephraimbuddy mentioned this pull request Aug 20, 2022
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@uranusjr uranusjr Awaiting requested review from uranusjr

Assignees
No one assigned
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.3.4
Development

Successfully merging this pull request may close these issues.

Airflow doesn't set default task group while calling dag.add_tasks
4 participants
@blcksrx @potiuk @uranusjr @ephraimbuddy