Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag link on dag detail page when setting base_url with url prefix #24918

Merged
merged 1 commit into from Jul 8, 2022

Conversation

xianghuzhao
Copy link
Contributor

This PR simply fix the tag link on dag detail page.
If use reverse proxy and set webserver.base_url with url prefix, these tag links will point to wrong locations.
Here just replace the direct link with url_for function.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 8, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 8, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@bbovenzi bbovenzi merged commit 24220bc into apache:main Jul 8, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 8, 2022

Awesome work, congrats on your first merged pull request!

@xianghuzhao xianghuzhao deleted the tag-link-dag-details-page branch July 12, 2022 08:21
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Aug 12, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.4 milestone Aug 12, 2022
ephraimbuddy pushed a commit that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants