New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong syntax in mssql setup documentation #24893
Comments
Thanks for opening your first issue here! Be sure to follow the issue template! |
Hi! I'm a newbie, I'll pick up this good-first-issue! |
Go ahead! |
In the 'set-up-databases' documentation the code block was not working on newer versions of mssql. Updated the docs so that the query works on supported 2017 and 2019 versions of mssql
All links below point to using new syntax Airflow supports the following database engine versions Tested on mssql 2017 and 2019, both worked fine with the new syntax Created a PR: #24939 |
Fixed in #24939. |
What do you see as an issue?
https://airflow.apache.org/docs/apache-airflow/stable/howto/set-up-database.html#setting-up-a-mssql-database
Documentation says:
GRANT ALL PRIVILEGES ON DATABASE airflow TO airflow_user;
For MSSQL 2019 patchlevel 15.0.4236.7 the correct syntax is:
GRANT ALL PRIVILEGES ON DATABASE::airflow TO airflow_user;
Only the latter works, although I still get a warning that it is deprecated.
Solving the problem
Updating documentation with new alternative, maybe depending on mssql version.
Anything else
No response
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: