Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriggerDagRunOperator.operator_extra_links is attr #24676

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Jun 27, 2022

There's absolutely no reason this needs to be a property. And it cannot be since we need to access this at the class level.

Fix #24653.

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Jun 27, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jun 27, 2022
There's absolutely no reason this needs to be a property. And it cannot
be since we need to access this at the class level.
@uranusjr uranusjr force-pushed the trigger-dag-run-operator-extra-links-attribute branch from 88769a8 to 759b6d1 Compare June 27, 2022 17:08
@uranusjr uranusjr merged commit 8dcafdf into apache:main Jun 28, 2022
@uranusjr uranusjr deleted the trigger-dag-run-operator-extra-links-attribute branch June 28, 2022 02:59
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.4 milestone Jul 7, 2022
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Jul 7, 2022
ephraimbuddy pushed a commit to astronomer/airflow that referenced this pull request Jul 11, 2022
There's absolutely no reason this needs to be a property. And it cannot
be since we need to access this at the class level.

(cherry picked from commit 8dcafdf)
ephraimbuddy pushed a commit that referenced this pull request Aug 15, 2022
There's absolutely no reason this needs to be a property. And it cannot
be since we need to access this at the class level.

(cherry picked from commit 8dcafdf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
3 participants