Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add hyperlinks to Github PRs for Release Notes #24532

Merged
merged 2 commits into from Jun 20, 2022

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jun 17, 2022

We missed it when we started using release-notes instead of changelogs.

Before:
image

After:
image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

We missed it when we started using release-notes instead of changelogs
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 17, 2022
@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Jun 19, 2022

Hey @kaxil - you need to rebase to check it. I think it was added at the moment when some css were failing at the image build stage, and I can't rebase it for you.

@uranusjr
Copy link
Member

That seems to work.

@uranusjr uranusjr merged commit abb8e44 into apache:main Jun 20, 2022
@uranusjr uranusjr deleted the add-gh-links branch June 20, 2022 05:46
@jedcunningham jedcunningham added this to the Airflow 2.3.4 milestone Aug 5, 2022
@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Aug 12, 2022
ephraimbuddy pushed a commit that referenced this pull request Aug 15, 2022
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
(cherry picked from commit abb8e44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart kind:documentation okay to merge It's ok to merge this PR as it does not require more tests type:doc-only Changelog: Doc Only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants