Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'airflow dags backfill --reset-dagruns' errors when run twice #21062

Merged
merged 1 commit into from Jan 27, 2022
Merged

Fix 'airflow dags backfill --reset-dagruns' errors when run twice #21062

merged 1 commit into from Jan 27, 2022

Conversation

uplsh580
Copy link
Contributor

@uplsh580 uplsh580 commented Jan 24, 2022 •
edited by uranusjr

See #21058

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 24, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uplsh580 uplsh580 force-pushed the fix-dags-backfill-error-when-run-twice branch from a3a4794 to 710d8fc Compare January 24, 2022 14:47
@uplsh580 uplsh580 changed the title fix dags backfill error when run twice Fix - Running airflow dags backfill --reset-dagruns <dag_id> -s <execution_start_dt> -e <execution_end_dt> results in error when run twice. Jan 24, 2022
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jan 26, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr
Copy link
Member

I modified the description to remove “close” so the issue stays open after we merge this. The issue is being used to also track the run-time check addition.

@uranusjr uranusjr mentioned this pull request Jan 26, 2022
Merged
@uplsh580 uplsh580 force-pushed the fix-dags-backfill-error-when-run-twice branch from 710d8fc to d4f45f1 Compare January 26, 2022 12:53
@uranusjr uranusjr added this to the Airflow 2.2.4 milestone Jan 27, 2022
@uranusjr uranusjr changed the title Fix - Running airflow dags backfill --reset-dagruns <dag_id> -s <execution_start_dt> -e <execution_end_dt> results in error when run twice. Fix 'airflow dags backfill --reset-dagruns' errors when run twice Jan 27, 2022
@uranusjr uranusjr merged commit d97e2ba into apache:main Jan 27, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 27, 2022

Awesome work, congrats on your first merged pull request!

@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Jan 27, 2022
jedcunningham pushed a commit that referenced this pull request Jan 27, 2022
@uplsh580 @jedcunningham
Fix 'airflow dags backfill --reset-dagruns' errors when run twice (#2…
b7438f7 
…1062)

Co-authored-by: uplsh <uplsh@linecorp.com>
(cherry picked from commit d97e2ba)
jedcunningham pushed a commit that referenced this pull request Jan 28, 2022
@uplsh580 @jedcunningham
Fix 'airflow dags backfill --reset-dagruns' errors when run twice (#2…
5fa0e13 
…1062)

Co-authored-by: uplsh <uplsh@linecorp.com>
(cherry picked from commit d97e2ba)
jedcunningham pushed a commit that referenced this pull request Feb 17, 2022
@uplsh580 @jedcunningham
Fix 'airflow dags backfill --reset-dagruns' errors when run twice (#2…
dda8f43 
…1062)

Co-authored-by: uplsh <uplsh@linecorp.com>
(cherry picked from commit d97e2ba)
@jedcunningham jedcunningham mentioned this pull request Feb 18, 2022
Closed
40 tasks
@ephraimbuddy ephraimbuddy mentioned this pull request Mar 27, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
area:CLI okay to merge It's ok to merge this PR as it does not require more tests type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.2.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uplsh580 @uranusjr @potiuk @jedcunningham