OpenApiSpec - DAGRun - make dag_id in body not required

[DrFaust92]

related: apache/airflow-client-go#9

When generating a golang client for the spec and trying to create a DAGRun. it requires the dag_id property in the body which the server refuses. see above linked issue.

Results for how code gen changes would look after the schema change can be seen here: https://github.com/DrFaust92/airflow-client-go/pull/2/files

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[ephraimbuddy]

This is a problem from the client generating the API not airflow.
And has been solved in openapi python client.
Issue: OpenAPITools/openapi-generator#9296
PR: OpenAPITools/openapi-generator#9409

You can create issue for it in the go client tool

[DrFaust92]

@ephraimbuddy, Thanks for the quick response. While I understand this may be an issue with an upstream tool. This makes it impossible to use golang generated client for managing DAG Runs at the moment.

My real question is, does my change break anything and is fundamentally wrong? my feeling (for my current understanding) is that its worth it.

[ephraimbuddy]

@ephraimbuddy, Thanks for the quick response. While I understand this may be an issue with an upstream tool. This makes it impossible to use golang generated client for managing DAG Runs at the moment.

My real question is, does my change break anything and is fundamentally wrong? my feeling (for my current understanding) is that its worth it.

I get your point now. Your code is actually fine. I think there's no harm.
@mik-laj WDYT

[github-actions]

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!