Fix opening "Task Instance Details" page in web UI unintentionally resets TaskInstance.max_tries #21018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
approved these changes
Jan 22, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
(cherry picked from commit e3832a7)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 28, 2022
(cherry picked from commit e3832a7)
jedcunningham
pushed a commit
that referenced
this pull request
Feb 17, 2022
(cherry picked from commit e3832a7)
40 tasks
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Feb 23, 2022
) (cherry picked from commit e3832a7)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #21017
Do not change
max_triesinrefresh_from_tasks(). This is to prevent the web UI from accidentally resetting the value ofmax_triesto the initial value and causing tasks in "reschedule" mode to raiseAirflowSensorTimeoutprematurely.Note that this PR only addresses the symptom reported in #21017. A more comprehensive fix should be to stop auto-committing the session in
views.pyin functions that are not supposed to modify the database. That can be done separately if someone is interested.