Switch to non-vendored latest connexion library #20910
Conversation
potiuk
requested review from
ashb,
bbovenzi,
ephraimbuddy,
mik-laj and
ryanahamilton
as code owners
potiuk
force-pushed
the
connexion-not-vendored-in
branch
2 times, most recently
from
95afcf9
to
5929a04
Compare
|
Right. Looks like the tests are all green when I replace vendored-in connexion with the latest version from PyPI (the failure was caused by temporary problem with GPG key when building PROD image). Is there anything else (besides running airflow + running some API calls and looking at the Swagger/API docs? Any other tests/expecrations for the connexion/API ? WDYT @mik-laj @uranusjr @ephraimbuddy ? |
|
BTW the prod image failure is actually due to this one #20889 - once this is merged, prod image should correctly use CI image with "connexion" installed from the PR rather than from "latest" main |
I think this part of the project has pretty good test coverage and we can rely on it. |
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
The `connexion` library has been vendored in because of requests library that used to have non-optional chardet LGPL dependency, however requests library had since released a version (which we helped to provide and convince the requests maintainer to merge) where chardet is an optional dependency (with mandatory charset_normalizer). This means that we do not need to vendor-in connexion any more. Also connexion after being somewhat abandoned, has been "revived" and there are active community now that maintains it - they released several new versions since 2.7.0 we used (2.10.0 is now the latest version, so we can upgrade to that version instead)
potiuk
force-pushed
the
connexion-not-vendored-in
branch
from
5929a04
to
853fdca
Compare
|
Cool. I also tested some basic API calls with the released client, as well as SWAGGER/Redoc and the manual testing also "looks good", |
The `connexion` library has been vendored in because of requests library that used to have non-optional chardet LGPL dependency, however requests library had since released a version (which we helped to provide and convince the requests maintainer to merge) where chardet is an optional dependency (with mandatory charset_normalizer). This means that we do not need to vendor-in connexion any more. Also connexion after being somewhat abandoned, has been "revived" and there are active community now that maintains it - they released several new versions since 2.7.0 we used (2.10.0 is now the latest version, so we can upgrade to that version instead) (cherry picked from commit 2c761cc)
The `connexion` library has been vendored in because of requests library that used to have non-optional chardet LGPL dependency, however requests library had since released a version (which we helped to provide and convince the requests maintainer to merge) where chardet is an optional dependency (with mandatory charset_normalizer). This means that we do not need to vendor-in connexion any more. Also connexion after being somewhat abandoned, has been "revived" and there are active community now that maintains it - they released several new versions since 2.7.0 we used (2.10.0 is now the latest version, so we can upgrade to that version instead) (cherry picked from commit 2c761cc)
The
connexionlibrary has been vendored in because of requestslibrary that used to have non-optional chardet LGPL dependency,
however requests library had since released a version (which we
helped to provide and convince the requests maintainer to merge)
where chardet is an optional dependency (with mandatory
charset_normalizer). This means that we do not need to vendor-in
connexion any more.
Also connexion after being somewhat abandoned, has been
"revived" and there are active community now that maintains it -
they released several new versions since 2.7.0 we used (2.10.0 is
now the latest version, so we can upgrade to that version instead)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.