bugfix: deferred tasks does not cancel when DAG is marked fail #20649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
requested changes
Jan 4, 2022
| @@ -70,7 +71,7 @@ def set_state( | |||
| past: bool = False, | |||
| state: TaskInstanceState = TaskInstanceState.SUCCESS, | |||
| commit: bool = False, | |||
| session=None, | |||
| session: SASession = None, | |||
There was a problem hiding this comment.
Please search for session: Session = NEW_SESSION for a more idomatic way to annotate this.
uranusjr
reviewed
Jan 4, 2022
Comment on lines
340
to
390
| # Mark only RUNNING task instances. | ||
| # Mark only running task instances. | ||
| task_ids = [task.task_id for task in dag.tasks] | ||
| tis = ( | ||
| session.query(TaskInstance) | ||
| .filter( | ||
| TaskInstance.dag_id == dag.dag_id, | ||
| TaskInstance.execution_date == execution_date, | ||
| TaskInstance.task_id.in_(task_ids), | ||
| TaskInstance.state.in_(State.running), | ||
| ) | ||
| .filter(TaskInstance.state == State.RUNNING) | ||
| ) |
There was a problem hiding this comment.
(Note for other reviewers) From what I can tell, this is the only functional change; all others are Mypy fixes.
uranusjr
approved these changes
Jan 4, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
ephraimbuddy
approved these changes
Jan 5, 2022
jedcunningham
pushed a commit
that referenced
this pull request
Jan 28, 2022
(cherry picked from commit 64c0bd5)
jedcunningham
pushed a commit
that referenced
this pull request
Feb 17, 2022
(cherry picked from commit 64c0bd5)
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: deferred tasks does not cancel when DAG is marked fail #20580 and fix typing
closes: #20580