Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicated dag_run join in Dag.get_task_instances() #20591

Merged
merged 4 commits into from Jan 27, 2022

Conversation

hubert-pietron
Copy link
Contributor

Related: #20248
Calling the Dag.get_task_instances() method would create warning sqlalchemy.exc.SAWarning: Pathed join target TaskInstance.dag_run has already been joined to; skipping, removed one of duplicated joins.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 30, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@kaxil kaxil added this to the Airflow 2.2.4 milestone Dec 30, 2021
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr
Copy link
Member

uranusjr commented Jan 6, 2022

I wish SQLAlchemy should be smarter about this and automatically ignore the duplicated join; this makes this sort of query-agumenting more robust (because removing duplicated join means the outer order_by() may break in the future if the implementation of _get_task_instances() changes). But this is what it is, we all know SQLAlchemy is far from perfect.

@uranusjr uranusjr changed the title Removed duplicated TaskInstance.dag_run in Dag.get_task_instances() Removed duplicated dag_run join in Dag.get_task_instances() Jan 27, 2022
@uranusjr uranusjr merged commit 960f573 into apache:main Jan 27, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 27, 2022

Awesome work, congrats on your first merged pull request!

@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Jan 27, 2022
jedcunningham pushed a commit that referenced this pull request Jan 28, 2022
Co-authored-by: hubert-pietron <hubert.pietron95@gmail.com>
(cherry picked from commit 960f573)
jedcunningham pushed a commit that referenced this pull request Feb 17, 2022
Co-authored-by: hubert-pietron <hubert.pietron95@gmail.com>
(cherry picked from commit 960f573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants