New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed duplicated dag_run join in Dag.get_task_instances() #20591
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
I wish SQLAlchemy should be smarter about this and automatically ignore the duplicated join; this makes this sort of query-agumenting more robust (because removing duplicated join means the outer |
Awesome work, congrats on your first merged pull request! |
Co-authored-by: hubert-pietron <hubert.pietron95@gmail.com> (cherry picked from commit 960f573)
Co-authored-by: hubert-pietron <hubert.pietron95@gmail.com> (cherry picked from commit 960f573)
Related: #20248
Calling the Dag.get_task_instances() method would create warning sqlalchemy.exc.SAWarning: Pathed join target TaskInstance.dag_run has already been joined to; skipping, removed one of duplicated joins.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.