Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling DAG.following_schedule() for TaskInstance.get_template_context() #20486

Merged
merged 2 commits into from Dec 28, 2021
Merged

Avoid calling DAG.following_schedule() for TaskInstance.get_template_context() #20486

merged 2 commits into from Dec 28, 2021

Conversation

uranusjr
Copy link
Member

This can use a more modern mechanism since get_template_context() has enough context (namely, the current data interval).

Fix #20475.

@uranusjr
Avoid calling following_schedule for ti context
e39ca4f 
This can use a more modern mechanism since get_template_context() has
enough context (namely, the current data interval).
@uranusjr
Test to ensure context works with custom timetable
fde0c32
@uranusjr uranusjr force-pushed the context-never-calls-deprecated branch from cd39b6a to e39ca4f Compare December 24, 2021 06:33
@uranusjr
Copy link
Member Author

uranusjr commented Dec 24, 2021 •
edited

I should add tests for this and all other context variables. Done

potiuk
potiuk approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@potiuk potiuk added this to the Airflow 2.2.4 milestone Dec 28, 2021
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 28, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 9e315ff into apache:main Dec 28, 2021
@uranusjr uranusjr deleted the context-never-calls-deprecated branch January 3, 2022 14:25
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Jan 20, 2022
jedcunningham pushed a commit that referenced this pull request Jan 21, 2022
@uranusjr @jedcunningham
Avoid calling DAG.following_schedule() for TaskInstance.get_template_…
b43882c 
…context() (#20486)

This can use a more modern mechanism since get_template_context() has
enough context (namely, the current data interval).

(cherry picked from commit 9e315ff)
@jedcunningham jedcunningham mentioned this pull request Feb 18, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

Assignees
No one assigned
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.2.4
Development

Successfully merging this pull request may close these issues.

Custom Timetable error with CeleryExecutor
3 participants
@uranusjr @potiuk @jedcunningham