Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecssary logging in experimental API #20356

Merged
merged 1 commit into from Dec 17, 2021

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Dec 16, 2021

The execution_data does not need to be passed to log. We send enough details to the API user in the response.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil requested a review from ashb December 16, 2021 22:40
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:webserver Webserver related Issues labels Dec 16, 2021
@kaxil kaxil marked this pull request as ready for review December 16, 2021 22:40
@kaxil kaxil closed this Dec 16, 2021
@kaxil kaxil reopened this Dec 16, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 16, 2021
@potiuk potiuk closed this Dec 16, 2021
@potiuk potiuk reopened this Dec 16, 2021
@potiuk
Copy link
Member

potiuk commented Dec 16, 2021

Looked like a strange temporary error - as if PYPI provided a bad output. Reopened to check it

The `execution_data` does not need to be passed to log. We send enough details to the API user in the response.
@potiuk potiuk merged commit 790bc78 into apache:main Dec 17, 2021
@kaxil kaxil deleted the given-exec-date branch December 17, 2021 21:41
@kaxil kaxil added this to the Airflow 2.2.4 milestone Dec 17, 2021
jedcunningham pushed a commit that referenced this pull request Jan 21, 2022
The `execution_data` does not need to be passed to log. We send enough details to the API user in the response.

(cherry picked from commit 790bc78)
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants