Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use seconds for schedule_delay metric when using dogstatsd #19973

Merged
merged 1 commit into from Dec 15, 2021

Conversation

lostkamp
Copy link
Contributor

@lostkamp lostkamp commented Dec 2, 2021

closes: #18599, #18622

This PR just fixes the failing test from a previos PR: #18622


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 2, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal requested a review from potiuk December 14, 2021 20:33
@ashb ashb changed the title Fix: Use seconds for schedule_delay metric Fix: Use seconds for schedule_delay metric when using dogstatsd Dec 15, 2021
@ashb ashb merged commit 5d405d9 into apache:main Dec 15, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 15, 2021

Awesome work, congrats on your first merged pull request!

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 15, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@ashb ashb added this to the Airflow 2.2.4 milestone Dec 15, 2021
@ashb
Copy link
Member

ashb commented Dec 15, 2021

I'm not sure if we are planning a 2.2.4 (or if we'll go straight to 2.3.0), but if we are I've marked it for inclusion there.

@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Dec 21, 2021
jedcunningham pushed a commit that referenced this pull request Jan 21, 2022
@lostkamp lostkamp deleted the fix-stats-timing branch May 30, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datadog parsing error for dagrun.schedule_delay since it is not passed in float type
3 participants