New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing ses email backend #18042
Fixing ses email backend #18042
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
I did some refactoring to bring the repeated code into a single piece of code. |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
@uranusjr there are a few tests failing which seem to be unrelated to the PR changes, shall I be doing anything regarding it? |
It seems like the CI failed since it ran out of resource. I think you can disregard those failures. |
Also see #18200. |
I would be goog to add a Closes: #17930 to the PR that way it will show on GitHub UI for that issue |
3e9ab47
to
6941318
Compare
I linked the issue (GitHub allows to link issue also via UI). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ it. One step closer to getting saner email configuration for various parts of Airflow.
5e26be7
to
69fc430
Compare
46bdbf5
to
ec86ca4
Compare
e9d5765
to
615a33d
Compare
@potiuk should we hold merging this PR as it will cause the Amazon provider to be depended on 2.3.0 ? |
According to the original issue, the only function this changes in the Amazon provider does not even work right now, so I don't think there's a compatibility issue since there's nothing to be compatible with. |
(cherry picked from commit 1543dc2)
Amazon SES Had a wrong signature to become a mailer in Airflow introduced in apache#18042. As the result setting SES emailer as email backend resulted in: ``` TypeError: send_email() missing 1 required positional argument: 'html_content' ``` Fixes: apache#21671
closes: #16166, #17930
related: #16778, #18200
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.