Fix impersonation issue with LocalTaskJob #16852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tasks with impersonation ( |
ashb
requested changes
Jul 7, 2021
ephraimbuddy
force-pushed
the
fix-run-as-user-pid
branch
from
13b172a
to
80421cb
Compare
ashb
reviewed
Jul 7, 2021
ashb
approved these changes
Jul 7, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
Running a task with run_as_user fails because PIDs are not matched correctly. This change fixes it by matching the parent process ID of the task instance to the current process ID of the task_runner process when we use impersonation Update tests/jobs/test_local_task_job.py Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> fixup! Update tests/jobs/test_local_task_job.py fixup! Fix impersonation issue with LocalTaskJob
ephraimbuddy
force-pushed
the
fix-run-as-user-pid
branch
from
d964204
to
f0e6ede
Compare
ashb
pushed a commit
that referenced
this pull request
Jul 7, 2021
Running a task with run_as_user fails because PIDs are not matched correctly. This change fixes it by matching the parent process ID (the `sudo` process) of the task instance to the current process ID of the task_runner process when we use impersonation Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> (cherry picked from commit feea380)
jhtimmins
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jul 9, 2021
Running a task with run_as_user fails because PIDs are not matched correctly. This change fixes it by matching the parent process ID (the `sudo` process) of the task instance to the current process ID of the task_runner process when we use impersonation Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> (cherry picked from commit feea380)
jhtimmins
pushed a commit
that referenced
this pull request
Jul 9, 2021
Running a task with run_as_user fails because PIDs are not matched correctly. This change fixes it by matching the parent process ID (the `sudo` process) of the task instance to the current process ID of the task_runner process when we use impersonation Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> (cherry picked from commit feea380)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jul 13, 2021
Running a task with run_as_user fails because PIDs are not matched correctly. This change fixes it by matching the parent process ID (the `sudo` process) of the task instance to the current process ID of the task_runner process when we use impersonation Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> (cherry picked from commit feea380) (cherry picked from commit 26a2beb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix impersonation issue with LocalTaskJob
Running a task with run_as_user fails because PIDs are not matched
correctly.
This change fixes it by matching the parent process ID of the task instance
to the current process ID of the task_runner process when we use impersonation
Fixes: #15537 (comment)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.