Always install sphinx_airflow_theme from pypi #16594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need a way to specify _in_ setup.py that this should be installed from a GitHub release -- it's never needed by users, and if you are developing the theme you can install the custom version yourself. (The variable name is confusing too -- it wasn't pulling from git, but from a published release on GitHub.) Removing this just means one less thing to update.
uranusjr
approved these changes
Jun 22, 2021
potiuk
approved these changes
Jun 22, 2021
ashb
added a commit
that referenced
this pull request
Jun 22, 2021
We don't need a way to specify _in_ setup.py that this should be installed from a GitHub release -- it's never needed by users, and if you are developing the theme you can install the custom version yourself. (The variable name is confusing too -- it wasn't pulling from git, but from a published release on GitHub.) Removing this just means one less thing to update. (cherry picked from commit 129fc61)
Jorricks
pushed a commit
to Jorricks/airflow
that referenced
this pull request
Jun 24, 2021
We don't need a way to specify _in_ setup.py that this should be installed from a GitHub release -- it's never needed by users, and if you are developing the theme you can install the custom version yourself. (The variable name is confusing too -- it wasn't pulling from git, but from a published release on GitHub.) Removing this just means one less thing to update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need a way to specify in setup.py that this should be
installed from a GitHub release -- it's never needed by users, and if
you are developing the theme you can install the custom version
yourself.
(The variable name is confusing too -- it wasn't pulling from git, but
from a published release on GitHub.)
Removing this just means one less thing to update.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.