Don't show stale Serialized DAGs if they are deleted in DB #16368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
force-pushed
the
dags-remove-dagbag
branch
from
a8c7c73
to
b533794
Compare
kaxil
force-pushed
the
dags-remove-dagbag
branch
from
b533794
to
a57c755
Compare
jedcunningham
approved these changes
Jun 10, 2021
kaxil
force-pushed
the
dags-remove-dagbag
branch
from
af4f6d1
to
42afb0d
Compare
ashb
reviewed
Jun 11, 2021
If `DagBag.get_dag()` is called currently, it will return the DAG even if the DAG does not exist in `serialized_dag` table. This PR changes that logic to remove the dag from local cache too when `DagBag.get_dag()` is called. This happens after `min_serialized_dag_fetch_secs`.
kaxil
force-pushed
the
dags-remove-dagbag
branch
from
42afb0d
to
fd42751
Compare
ashb
approved these changes
Jun 11, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
ashb
pushed a commit
that referenced
this pull request
Jun 22, 2021
If `DagBag.get_dag()` is called currently, it will return the DAG even if the DAG does not exist in `serialized_dag` table. This PR changes that logic to remove the dag from local cache too when `DagBag.get_dag()` is called. This happens after `min_serialized_dag_fetch_secs`. (cherry picked from commit e3b3c1f)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 22, 2021
) If `DagBag.get_dag()` is called currently, it will return the DAG even if the DAG does not exist in `serialized_dag` table. This PR changes that logic to remove the dag from local cache too when `DagBag.get_dag()` is called. This happens after `min_serialized_dag_fetch_secs`. (cherry picked from commit e3b3c1f)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 23, 2021
) If `DagBag.get_dag()` is called currently, it will return the DAG even if the DAG does not exist in `serialized_dag` table. This PR changes that logic to remove the dag from local cache too when `DagBag.get_dag()` is called. This happens after `min_serialized_dag_fetch_secs`. (cherry picked from commit e3b3c1f) (cherry picked from commit 9d14b1d)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 23, 2021
) If `DagBag.get_dag()` is called currently, it will return the DAG even if the DAG does not exist in `serialized_dag` table. This PR changes that logic to remove the dag from local cache too when `DagBag.get_dag()` is called. This happens after `min_serialized_dag_fetch_secs`. (cherry picked from commit e3b3c1f) (cherry picked from commit 9d14b1d) (cherry picked from commit c95f6d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
DagBag.get_dag()is called currently, it will return the DAGeven if the DAG does not exist in
serialized_dagtable.This PR changes that logic to remove the dag from local cache too
when
DagBag.get_dag()is called. This happens aftermin_serialized_dag_fetch_secs.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.