New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding extra requirements for build and runtime of the PROD image. #16170
Adding extra requirements for build and runtime of the PROD image. #16170
Conversation
bca73c2
to
9d3a9f2
Compare
hmm .. build docs is failing |
fixed |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
fb98222
to
a0cfe41
Compare
Good point @mik-laj. But rather than creating a new section, I extended two sections in the helm chart docs:
I think that hits the sweet-spot between copy/pasting some parts of documentation where users might need it and having common source of examples. |
1cc6d88
to
0744dfe
Compare
Last comments please :) |
docs/docker-stack/docker-examples/customizing/github-different-repository.sh
Outdated
Show resolved
Hide resolved
2048b3e
to
4f55a07
Compare
This PR adds capability of adding extra requirements to PROD image: 1) During the build by placing requirements.txt in the ``docker-context-files`` folder 2) During execution of the container - by passing _PIP_ADDITIONAL_REQUIREMENTS variable The second case is only useful durint quick test/development and should not be used in production. Also updated documentation to contain all development/test variables for docker compose and clarifying that the options starting with _ are ment to be only used for quick testing.
4f55a07
to
150a48d
Compare
…pache#16170) This PR adds capability of adding extra requirements to PROD image: 1) During the build by placing requirements.txt in the ``docker-context-files`` folder 2) During execution of the container - by passing _PIP_ADDITIONAL_REQUIREMENTS variable The second case is only useful durint quick test/development and should not be used in production. Also updated documentation to contain all development/test variables for docker compose and clarifying that the options starting with _ are ment to be only used for quick testing. (cherry picked from commit d245992)
Hello,
I'm using this but didn't get good results. I want to install pydub, dropbox through docker compose file. Is it right syntax or what's wrong with it ? |
Thanks @potiuk for a quick reply. But I saw this page actually but umm, okay. Can you write down a command which I put in compose file for installing |
Just set env variables. Here is the first googled result about them https://opensource.com/article/19/8/what-are-environment-variables#:~:text=Environment%20variables%20contain%20information%20about,during%20installation%20or%20user%20creation. To be perfectly honest - don't even try docker-compose if you find it difficult to set environment variable when you run a command. this is really basic thing. You should try to undrstand what you do and not ask someone to copy you some solutions to most basic things. |
Hmm Actually I tried this command too ::
|
Thanks @potiuk |
This PR adds capability of adding extra requirements to PROD image:
During the build by placing requirements.txt in the
docker-context-files
folderDuring execution of the container - by passing
_PIP_ADDITIONAL_REQUIREMENTS variable
The second case is only useful durint quick test/development and
should not be used in production.
Also updated documentation to contain all development/test
variables for docker compose and clarifying that the options
starting with _ are ment to be only used for quick testing.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.