Removes unnecessary packages from setup_requires #16139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @uranusjr |
potiuk
force-pushed
the
remove-unnecessary-packages-from-setup-requires
branch
from
15bb346
to
7834585
Compare
uranusjr
approved these changes
May 28, 2021
mik-laj
approved these changes
May 28, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
approved these changes
May 28, 2021
This change removes unnecessary dependencies from setup_requires: * docutils are not needed in setup requires and actually having them here caused harmful upgrade even if docutils are limited to <0.17 elsewhere * setup_tools should not be needed in setup_requires (by the time setup_requires are parsed, they should be already installed * bowler is not needed any more in setup.py (we got rid of it when we got rid of backport packages. Also docutils<0.17 limitation is moved to install_requires because docutils was already a transitive dependency of airflow without extras and it could be upgraded even if there is a limitation in extra.
potiuk
force-pushed
the
remove-unnecessary-packages-from-setup-requires
branch
from
7834585
to
96ef5fc
Compare
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 22, 2021
This change removes unnecessary dependencies from setup_requires: * docutils are not needed in setup requires and actually having them here caused harmful upgrade even if docutils are limited to <0.17 elsewhere * setup_tools should not be needed in setup_requires (by the time setup_requires are parsed, they should be already installed * bowler is not needed any more in setup.py (we got rid of it when we got rid of backport packages. Also docutils<0.17 limitation is moved to install_requires because docutils was already a transitive dependency of airflow without extras and it could be upgraded even if there is a limitation in extra. (cherry picked from commit b605987)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes unnecessary dependencies from setup_requires:
having them here caused harmful upgrade even if docutils
are limited to <0.17 elsewhere
the time setup_requires are parsed, they should be already
installed
when we got rid of backport packages.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.