Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max tree view width to 1200px #16067

Merged
merged 2 commits into from May 25, 2021
Merged

Conversation

bbovenzi
Copy link
Contributor

Add a max width of 1200px to the tree view diagram to keep readability on large monitors.

Fixes: #16024


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

the totalwidth of the tree view will depend on the window size like before, but max out at 1200px
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels May 25, 2021
@bbovenzi bbovenzi changed the title Set max tree width to 1200px Set max tree view width to 1200px May 25, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 25, 2021
@ashb
Copy link
Member

ashb commented May 25, 2021

@bbovenzi Rebase please --

@bbovenzi
Copy link
Contributor Author

Rebased

@ashb ashb merged commit f2aa9b5 into apache:master May 25, 2021
@ashb ashb deleted the max-tree-width branch May 25, 2021 20:20
@bbovenzi bbovenzi added this to the Airflow 2.1.1 milestone Jun 4, 2021
jhtimmins pushed a commit that referenced this pull request Jun 10, 2021
the totalwidth of the tree view will depend on the window size like before, but max out at 1200px

(cherry picked from commit f2aa9b5)
ashb pushed a commit that referenced this pull request Jun 22, 2021
the totalwidth of the tree view will depend on the window size like before, but max out at 1200px

(cherry picked from commit f2aa9b5)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Jun 22, 2021
the totalwidth of the tree view will depend on the window size like before, but max out at 1200px

(cherry picked from commit f2aa9b5)
(cherry picked from commit eefa563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

airflow 2.1.0 - squares with tasks are aligned far to the right
3 participants