New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make task ID on legend have enough width and width of line chart to be 100%. #15915
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. but it may be helpful to show a before and after screenshot in the PR.
Add before and after screenshot |
What happens if the screen width is below 1200px, or much narrower? I would want the chart to have a minimal width so it is still usable on small screens. |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some pylint errors need fixing
@ryanahamilton can you take a look and confirm whether your requested changes have been addressed? |
Awesome work, congrats on your first merged pull request! |
…e 100%. (apache#15915) * Make task ID on legend have enough width and width of line chart to be 100%. * Make task ID on legend have enough width and width of line chart to be 100%. * Fix pylint errors. (cherry picked from commit 6e9e562) (cherry picked from commit fb62867)
…e 100%. (apache#15915) * Make task ID on legend have enough width and width of line chart to be 100%. * Make task ID on legend have enough width and width of line chart to be 100%. * Fix pylint errors. (cherry picked from commit 6e9e562) (cherry picked from commit fb62867) (cherry picked from commit 8b2a7b7)
On Task Duration/Task Tries/Lading Times, the full name of task ID is cutted and end with '...' if lenght is over that 20 characters. So we make task ID have enough width (max length: 200 characters ) to be displayed and let user can find out matched Task ID when pressing CTRL+F and inputting long text.
Width of line chart was set to 1200 , it looks not good for big screens, it should be 100% width.
Please compare the before and after screenshot.
Before:
After: