Ensure that dag_run conf is a dict #15057
Conversation
boring-cyborg
bot
added
area:API
jscheffl1
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
| @@ -426,7 +426,7 @@ def load_file( | |||
| if create or recreate: | |||
| if field_dict is None: | |||
| raise ValueError("Must provide a field dict when creating a table") | |||
| fields = ",\n ".join(['`{k}` {v}'.format(k=k.strip('`'), v=v) for k, v in field_dict.items()]) | |||
| fields = ",\n ".join([f"`{k.strip('`')}` {v}" for k, v in field_dict.items()]) | |||
There was a problem hiding this comment.
This change looks unrelated -- is it?
There was a problem hiding this comment.
Hi @ashb Yes, the changes in hive.py were unrelated but the test scripts failed on this preventing me to open the PR. I needed to fix there... don't know why :-(
There was a problem hiding this comment.
It should be ignored if you don't otherwise change the file.
ashb
changed the title
|
@jscheffl Could you rebase this change please? (We split tests_views.py in to multiple files). |
|
@ashb uups, something went bad in the rebase, will need one further attempt to integrate on rebase... |
|
Ready for review (again) |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
Awesome work, congrats on your first merged pull request! |
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> (cherry picked from commit 01c9818)
|
@ashb Thanks for finalizing the merge! Looking forward for the next PR - I already have an idea what to contribute next... and hope I'll find some weekend time soon. |
|
@jscheffl This PR will be in 2.1.1 too -- I merged it just before the freeze for release prep |
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
There was a bad cherry-pick when merging apache#15057 that has not been caught because of quarantined test. Fixes: apache#16810
With this PR new DAG triggers are validated that the submitted conf (=dag_run_conf) is a dictionary. Previously submissions were possible and the logic just validated if the parameter is a valid JSON. Nevertheless currently some business logic fails in Airflow if the con value is not a dictionary object.
Explicitly I added the validation NOT to the data model as instances with migrated legacy data (in Airflow 1.x non dictionary cases were supported) are not failing in loading data via ORM.
The PR mainly adds validation for Legacy Experimental API and WWW UI.
It adds pytest for Legacy Experimental API, "new" API and WWW UI.
Update Pylint and flynt
closes: #15023
related: #15023