From e27e44da52c0bd3fbf2d027923f9ff1e8f3a1364 Mon Sep 17 00:00:00 2001 From: wself Date: Sat, 16 Jul 2022 12:23:03 +0300 Subject: [PATCH] Add test for load kube client with disable ssl --- airflow/kubernetes/kube_client.py | 5 ++++- tests/kubernetes/test_client.py | 13 +++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/airflow/kubernetes/kube_client.py b/airflow/kubernetes/kube_client.py index df18822f8dfda..c42ef6191f974 100644 --- a/airflow/kubernetes/kube_client.py +++ b/airflow/kubernetes/kube_client.py @@ -30,7 +30,10 @@ has_kubernetes = True def _disable_verify_ssl() -> None: - configuration = Configuration.get_default_copy() + if hasattr(Configuration, 'get_default_copy'): + configuration = Configuration.get_default_copy() + else: + configuration = Configuration() configuration.verify_ssl = False Configuration.set_default(configuration) diff --git a/tests/kubernetes/test_client.py b/tests/kubernetes/test_client.py index ce040cf3ed8f2..d144456c49e05 100644 --- a/tests/kubernetes/test_client.py +++ b/tests/kubernetes/test_client.py @@ -38,6 +38,19 @@ def test_load_file_config(self, config): assert config.load_incluster_config.not_called assert config.load_kube_config.called + @mock.patch('airflow.kubernetes.kube_client.config') + @mock.patch('airflow.kubernetes.kube_client.conf') + def test_load_config_disable_ssl(self, conf, config): + conf.getboolean.return_value = False + get_kube_client(in_cluster=False) + conf.getboolean.assert_called_with('kubernetes', 'verify_ssl') + # Support wide range of kube client libraries + if hasattr(Configuration, 'get_default_copy'): + configuration = Configuration.get_default_copy() + else: + configuration = Configuration() + self.assertFalse(configuration.verify_ssl) + def test_enable_tcp_keepalive(self): socket_options = [ (socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1),