Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Build broken due to eslint 5.14.0 #102

Closed
kristw opened this issue Feb 15, 2019 · 2 comments · Fixed by #106
Closed

Build broken due to eslint 5.14.0 #102

kristw opened this issue Feb 15, 2019 · 2 comments · Fixed by #106
Labels
#bug Something isn't working #build Development environment

Comments

@kristw
Copy link
Contributor

kristw commented Feb 15, 2019 •
edited

Describe the bug
eslint just releases a new version that has a bug.

To Reproduce
Steps to reproduce the behavior:
See CI

Expected behavior
CI completes successfully

Additional context
I have opened an issue and submit PR to eslint, but it may take some time until they release a new version. We have to pin our eslint to 5.13.0 meanwhile.

eslint/eslint#11402
eslint/eslint#11403
@kristw kristw added #bug Something isn't working #build Development environment labels Feb 15, 2019
@kristw
Copy link
Contributor Author

kristw commented Feb 16, 2019

Forking @superset-ui/build-config from @data-ui/config and pin eslint to 5.13.0 for now until the patch from eslint has been released.

@kristw
Copy link
Contributor Author

kristw commented Feb 19, 2019

eslint has released 5.14.1. Will update shortly.

@kristw kristw mentioned this issue Feb 19, 2019
Merged
kristw added a commit that referenced this issue Apr 17, 2020
@kristw
fix: invalid margin breaking chart (#102)
6aa8d00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
#bug Something isn't working #build Development environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Update build config version apache-superset/superset-ui
1 participant
@kristw