Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only expose the Settings you have to #7

Closed
epage opened this issue Jan 21, 2022 · 5 comments · Fixed by #17
Closed

Only expose the Settings you have to #7

epage opened this issue Jan 21, 2022 · 5 comments · Fixed by #17

Comments

@epage
Copy link

epage commented Jan 21, 2022

We are looking at dropping settings (see clap-rs/clap#2717). Limiting your support for them would ease the transition when this happens (data model transitions are a hard thing to document appropriately)
@aobatact
Copy link
Owner

Does this means to drop support of deprecated items in ArgSettings and AppSettings?
I've already remove those variant.

@epage
Copy link
Author

epage commented Jan 22, 2022

I'd recommend to only expose Arg functions and not ArgSettings in preparation for us removing ArgSettings (ideally in clap4, maybe as late as clap5)

@aobatact
Copy link
Owner

Thank you for clarification!
I'll work it now.

@aobatact
Copy link
Owner

Is this only for ArgSetting or also AppSetting?

@epage
Copy link
Author

epage commented Jan 23, 2022

AppSettings will also be going away but there is not an alternative API for users to call at this time.

I suggested ArgSettings because there is a function for every setting.

@aobatact aobatact mentioned this issue Jan 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ArgSettings support aobatact/clap-serde
2 participants
@epage @aobatact