Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solana 1.18.8 hangs when deploying #1018

Open
b1acKr0se opened this issue Apr 24, 2024 · 11 comments
Open

Solana 1.18.8 hangs when deploying #1018

b1acKr0se opened this issue Apr 24, 2024 · 11 comments

Comments

@b1acKr0se
Copy link

Problem

When running solana program deploy with solana v1.18.8, the process will hang indefinitely and not resign/resend transactions after a while. There's no 5 retries like previous versions.

⠲   1.6% | Resent 1132 transactions...              [block height 241935494; re-sign in 0 blocks] 

This causes the buffer account's seed phrase to never be printed, therefore the only option left is to close the buffer account through solana program close.

Proposed Solution

It should throw an error together with the seed phrase of the buffer account like it did before, so we know when to restart/resume the deploy.

@b1acKr0se
Copy link
Author

Same with 1.18.11, even with high --max-sign-attempts, it will hang after the first block height becomes invalid.

@valentinmadrid
Copy link

Same issue here, and have also seen other people encountering it.

@sjoerd-dijkstra
Copy link

Same issue, across multiple versions and architectures. Don't know how to get past it..

@b1acKr0se
Copy link
Author

Same issue, across multiple versions and architectures. Don't know how to get past it..

I had to fork the 1.14.29 version and made a change to the number of retry attempts. It finally worked after about 30 retries...

@sjoerd-dijkstra
Copy link

Same issue, across multiple versions and architectures. Don't know how to get past it..

I had to fork the 1.14.29 version and made a change to the number of retry attempts. It finally worked after about 30 retries...

Can confirm this works. Forked and changed the retry amount and it's not hanging. Thanks!

https://github.com/solana-labs/solana/blob/v1.14.29/client/src/tpu_client.rs#L224

@phumaster
Copy link

Same issue, across multiple versions and architectures. Don't know how to get past it..

I had to fork the 1.14.29 version and made a change to the number of retry attempts. It finally worked after about 30 retries...

It works. Thanks, you saved my life <3

@bshumi
Copy link

bshumi commented Apr 25, 2024

Even 30 retries didn't help. Seems, I should add prioritization fee to the old cli.

@ad7090
Copy link

ad7090 commented Apr 27, 2024

Same issue #35534

@enzoampil
Copy link

enzoampil commented Apr 29, 2024

Making a fork, adding a timeout to send_and_confirm_transactions_in_parallel.rs (using time::timeout), and then applying retries on the same buffer account fixed it for me.

Athough it's really slow but did the job eventually (40 retries over 1.5 hours)

@enzoampil
Copy link

Working for me now with --use-rpc flag and helius + jito + ironforge RPC on 1.18.12

@jacobcreech
Copy link

jacobcreech commented May 7, 2024

CLI: 1.18.12

Verified it wasn't a swallowing of 429s by running solana program deploy target/deploy/deployment.so --with-compute-unit-price 1000 --max-sign-attempts 1000 with a known rated limited 429 endpoint, got thrown:

Error: HTTP status client error (429 Too Many Requests) for url XXXX

Found that hanging doesn't actually happen, but time between re-sign in 0 blocks and Blockhash expired. 997 retries remaining is measured in minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants