Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urfave-cli changes are breaking builds #3

Closed
calthomson opened this issue Nov 12, 2019 · 4 comments
Closed

urfave-cli changes are breaking builds #3

calthomson opened this issue Nov 12, 2019 · 4 comments

Comments

@calthomson
Copy link
Contributor

Recent changes to a dependency of this project, urfave-cli, are causing an error in this project:


# github.com/anubhavmishra/envoy-consul-sds
--
  | src/github.com/anubhavmishra/envoy-consul-sds/main.go:51:14: cannot use cli.IntFlag literal (type cli.IntFlag) as type cli.Flag in array or slice literal:
  | cli.IntFlag does not implement cli.Flag (Apply method has pointer receiver)
  | src/github.com/anubhavmishra/envoy-consul-sds/main.go:56:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
  | cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
  | src/github.com/anubhavmishra/envoy-consul-sds/main.go:61:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
  | cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
  | src/github.com/anubhavmishra/envoy-consul-sds/main.go:66:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
  | cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
  | src/github.com/anubhavmishra/envoy-consul-sds/main.go:70:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
  | cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
  | src/github.com/anubhavmishra/envoy-consul-sds/main.go:75:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
  | cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)

Here is an example of this issue someone posted in the urfave/cli project: urfave/cli#926

Seems like it's going to be broken for projects that don't have go modules. Can we add go modules to this project?

@coilysiren
Copy link

@calthomson in case you haven't seen it already, here's a PR where someone fixes this purpleidea/mgmt#571

@calthomson, @anubhavmishra if / when you fix the problem here, can ya cc me? I want to make sure I know how people are fixing this 🙏

@calthomson
Copy link
Contributor Author

@lynncyrin

I forked the repo, added go modules, and updated the code to work with the latest urfave/cli changes. Created a PR in case you're interested: #4

@anubhavmishra
Copy link
Owner

@calthomson Thank you so much for the pull request. I will be merging it soon. 👍🏽

@anubhavmishra
Copy link
Owner

anubhavmishra commented Nov 17, 2019

Merged: #4 so I am closing this issue. Once again, thank you @calthomson. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants