Skip to content

fix(area-shape): fix marker fillOpacity #4017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

itiiss
Copy link
Contributor

@itiiss itiiss commented Jun 30, 2022

Checklist
  • [✅ ] npm test passes
  • [ ✅] tests and/or benchmarks are included
  • [✅ ] commit message follows commit guidelines
Description of change
before after
 截屏2022-06-30 下午12 36 52 截屏2022-06-30 下午12 32 59

area-area 和 area-smooth 这两种内置shape的默认getMarker没有初始的的fillOpacity值,导致使用了默认主题中areaFillOpacity=0.25的值
fixed #3123

@coveralls
Copy link

coveralls commented Jul 4, 2022

Pull Request Test Coverage Report for Build 2587567875

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 91.271%

Files with Coverage Reduction New Missed Lines %
src/chart/controller/gesture.ts 7 82.14%
Totals Coverage Status
Change from base Build 2582561281: -0.05%
Covered Lines: 11820
Relevant Lines: 12458

💛 - Coveralls

@visiky visiky merged commit 9789742 into antvis:master Jul 4, 2022
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

🎊 PR Preview 9789742 has been successfully built and deployed to https://antvis-G2-preview-pr-4017.surge.sh?type=diff&date=2022-07-04

🕐 Build time: 69.372s

🤖 By Surge Ui Insight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

面积图使用 .shape 后,legend 的颜色会变浅
4 participants