fix(bar): 修复条形图在 reflect y 时，绘制圆角错误 #3745
Merged
+119
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😭 Deploy PR Preview 048a492 failed. Build logs
🤖 By surge-preview |
hustcc
reviewed
Dec 14, 2021
visiky
commented
Dec 14, 2021
| if (coordinate.isReflect('x')) { | ||
| [p0, p3] = swap(p0, p3); | ||
| [p1, p2] = swap(p1, p2); | ||
| } |
There was a problem hiding this comment.
之前写复杂了，只要根据 coordinate 的转换为 points 以及 radius 转换就行 （radius 只考虑在转置下的一个坐标转换）
visiky
force-pushed
the
fix-3743
branch
2 times, most recently
from
305808b to
f0e0b96
Compare
hustcc
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
close: #3743