Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(funnel): 漏斗图转化率文本位置获取修改 #3354

Merged
merged 2 commits into from
Nov 4, 2022
Merged

fix(funnel): 漏斗图转化率文本位置获取修改 #3354

merged 2 commits into from
Nov 4, 2022

Conversation

ai-qing-hai
Copy link
Contributor

@ai-qing-hai ai-qing-hai commented Sep 15, 2022 •
edited

  • 漏斗图转化率文本 afterrender 后重新修改
  • 漏斗图转化率文本 通过形状获取 x 位置信息
  • 对比漏斗图还未更改，动态不用更改
  • 兼容其他 annotations , 不至于全部删除

fixed #3350

before after
image image image

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022 •
edited

🎊 PR Preview b7923d7 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-3354.surge.sh?type=diff&date=2022-09-16

🕐 Build time: 73.911s

🤖 By Surge Ui Insight

@github-actions github-actions bot added bugfix and removed bugfix labels Sep 16, 2022
@visiky visiky requested a review from hustcc September 23, 2022 09:31
@visiky visiky merged commit 4e28638 into master Nov 4, 2022
@visiky visiky deleted the fix-funnel-conversion-tag branch November 4, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc left review comments

@visiky visiky Awaiting requested review from visiky

Assignees
No one assigned
Labels
bugfix PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🥰 [FEATURE] 漏斗图在隐藏图例的同时能否同时把转化率隐藏
3 participants
@ai-qing-hai @hustcc @visiky