Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(heatmap): 修复色力图 coordinate部分配置不起效 和 配置了 refect coordinate 失效的问题 #3294

Merged
merged 6 commits into from
Jul 28, 2022
Merged

fix(heatmap): 修复色力图 coordinate部分配置不起效 和 配置了 refect coordinate 失效的问题 #3294

merged 6 commits into from
Jul 28, 2022

Conversation

ai-qing-hai
Copy link
Contributor

  • 修复色力图 coordinate部分配置不起效
  • 配置了 refect coordinate 失效的问题
Before After
image image.png

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022 •
edited

🎊 PR Preview 827580b has been successfully built and deployed to https://antvis-G2Plot-preview-pr-3294.surge.sh?type=diff&date=2022-07-25

🕐 Build time: 82.137s

🤖 By Surge Ui Insight

visiky
visiky requested changes Jul 25, 2022
View reviewed changes
src/plots/heatmap/adaptor.ts Outdated Show resolved Hide resolved
@ai-qing-hai
Copy link
Contributor Author

ai-qing-hai commented Jul 25, 2022 •
edited

@visiky 我觉得现在的刚刚好， deepAssign 后面的 actions 会覆盖前面的，并没有和 coordinate 的 actions 合并， 与其在此修改， 不如现在的代码清晰。

@visiky visiky merged commit 45d60d7 into master Jul 28, 2022
@visiky visiky deleted the fix-heatmpa-coordinate branch July 28, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc left review comments

@visiky visiky visiky requested changes

Assignees
No one assigned
Labels
bugfix PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ai-qing-hai @hustcc @visiky