fix(gauge): 仪表盘 percent 0 时，数据被过滤重新添加回来 #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview d715457 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-3265.surge.sh?type=diff&date=2022-06-30 🕐 Build time: 70.313s
🤖 By Surge Ui Insight |
hustcc
reviewed
Jun 27, 2022
hustcc
reviewed
Jun 28, 2022
|
单侧报错。 |
visiky
reviewed
Jun 30, 2022
src/plots/gauge/utils.ts
Outdated
| @@ -37,6 +35,7 @@ export function getIndicatorData(percent: GaugeOptions['percent']): Data { | |||
| export function getRangeData(percent: GaugeOptions['percent'], range?: GaugeOptions['range']): GaugeRangeData { | |||
| const ticks = get(range, ['ticks'], []); | |||
|
|
|||
| const clampTicks = size(ticks) ? ticks : [0, clamp(percent, 0, 1), 1]; | |||
| const clampTicks = size(ticks) ? uniq(ticks) : [0, clamp(percent, 0, 1), 1]; | |||
| !clampTicks[0] && clampTicks.shift(); | |||
There was a problem hiding this comment.
如果 clampTicks[0] 等于 0，不就是被过滤掉了吗？
按照下面的方式，在最后的时候，去重下就好了？
const clampTicks = size(ticks) ? ticks : [0, clamp(percent, 0, 1), 1];
processRangeData(uniq(clampTicks) as number[], percent);
There was a problem hiding this comment.
原先解决的问题 是 percent 为 0 时 被过滤掉 只有一个 1 的数据， 导致 仪表盘 percent 为0 时 显示为 100%. 现在的解法是去除 为 0 的过滤， 把 ticks 去重。 关键点： 第一个为 0 的数据 是不渲染的，如果单单 uniq 则会让 第一个为 0 的数据会用掉一个颜色，导致颜色显示差一位。
|
这个 PR 我先合并了。然后复现 桑基图测试问题的 demo 链接有吗？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
仪表盘 percent 0 时，数据被过滤. 导致 geometry 渲染第一个 range 直接为 1
fixed #3262