New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
master branch: the C++ runtime does not build with VS2019 @antlr4\runtime\Cpp\runtimeantlr4cpp-vs2019.vcxproj #3730
Comments
Correct, it will be fixed by #3725 |
Also, please actual branch |
@KvanTTT the branch dev has the same problem: |
Yes, but PR hasn't been merged yet. |
Ok...objective is to update this pull request: Nuget packages for ANTLR 4 |
BTW, I removed support of VS < 2019 and added support of VS 2022. |
I go not understand how this project is running. Even the tag 4.10.1 does not compile
Cpp runtime compilation with VS20129 is also failing!!! When this PR #3725 will be applied?
|
Yes, because it was not checked before release. |
Not sooner than Windows CI for C++ is fixed (see comments). But I can just to ignore these test if you'd like to get fixes ASAP. |
Not really needed. Just give me a release that compile fine with vs2019 |
@KvanTTT Could you tell me which tag/release is the good one for getting a clean compile with vS2019? |
You can get the solution from my branch runtime-tests-fixes. |
@KvanTTT I cloned your repo/branch as stated. There are 2 errors
|
Weird, I'll take a look later. I have building without errors. |
Here the same issue reported and the fix: #3656 |
Applying the fix leads now to
|
Could you please use English locale for error messages? |
"error LNK2019: symbole externe non résolu" means external symbol unresolved. The remainging is pure C++ mangling stuff |
Adding Utf8.h/cpp to support directory solves the linker issue |
I had these errors only for demo app, but I've also already fixed it. |
Could you make this warning ignored. It pollutes a lot the compiling log |
I doubt I can. It's out of my priority for now and I'm not very experienced in C++. Maybe @jcking could help. |
Here the fix: In antlr4-common.h, could you add the line below at line 44 |
Could you suggest a fix? Experienced guys will take a look. |
The fix is in the comment above your last note |
I made the PR #3741 for building the ANTLR4 C++ Runtime as 3 Nuget packages. This PR does not change anything, just add a directory. |
I am also unable to compile the runtime. I am just starting with ANTLR4 to get familiar with it. We want to use it to replace the proprietary parsers in SourceMonitor. |
@ThirtySomething Meantime the master branch be fixed, you can get this PR to compile the ANTLR C++ runtime: PR3741 |
@zosrothko thanks for the hint. Unfortunately I don't know how to handle this. Until I've startet to maintain SourceMonitor a few months ago, I was using git/GitHub as single developer like SVN... Do I have to fork your fork of ANTLR4 to get the the PR? |
Not |
@zosrothko @KvanTTT I've did a local checkout of zosrothko/antlr4, switched to the dev branch and the compile works well. Thank you for your support. |
@zosrothko I guess the issue can be closed. |
I would welcome the merge of @zosrothko's PR. There are differences between the dev branch of ANTLR and zosrothko's dev branch resulting in inconsistencies between the generated code and the runtime. |
Could you point the differences between ANTLR and @zosrothko's dev branches? |
@KvanTTT I'm sorry, there was a problem with my setup. I was a little bit confused about the different repos and branches. But I've got my project compiling. The compile errors belong to a misconfiguration of my project and not to the different repos/branches. With the ANTLR4/dev branch everything works well. |
@parrt or @zosrothko please close the issue. |
Hello
Building the VS2019 C++ runtime for the master branch version 4.10.2-SNAPSHOT does not build. See the log below
L'opération de génération a démarré...
The text was updated successfully, but these errors were encountered: