[C++] Fix bugs in ParserATNSimulator and PredictionContextMergeCache #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin King <jcking@google.com>
|
Signed-off-by: Justin King <jcking@google.com>
|
No, this is purely C++. During a refactor I accidentally started the for loop at 0 instead of 1. Really catching bugs like this needs overall better testing, as the grammar needs to exercise the code path. Surelog caught this bug during testing. |
|
This also fixes #3643. |
jcking
changed the title
…ble resources Signed-off-by: Justin King <jcking@google.com>
|
Thanks!!! I will try to release today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3641 which I accidentally introduced during a refactor, by starting by 0 when the original started at 1. Also fixes #3643.