Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issue#26 #31

Open
wants to merge 1 commit into
base: 1.0.x
Choose a base branch
from

Conversation

peter279k
Copy link
Member

Description

Closes #26.

Motivation and context

For issue #26.

How has this been tested?

N/A

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@peter279k peter279k self-assigned this Nov 26, 2021
@peter279k peter279k added the enhancement New feature or request label Nov 26, 2021
@peter279k peter279k force-pushed the issue_#26 branch 4 times, most recently from 7c6bfec to 9606bee Compare November 26, 2021 04:43
@peter279k
Copy link
Member Author

They're all done excluding Psalm static analysis checking.

@kpicaza
Copy link
Member

kpicaza commented Nov 26, 2021

We can merge it, as it is already unreleased, and I can dedicate some time to get them passing 🚀🚀🚀 Thanks Again @peter279k you are awesome ;-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding PHP 8.0 version support
2 participants