fix: import .mjs version of vue-composition-api #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would on hold this for a while. Even tho I believe this is the right thing to do eventually, I am afraid that the existing community still needs some time to catch up (vuejs/composition-api#815) The current workaround might be setting the alias manually: alias: {
'@vue/composition-api/dist/vue-composition-api.esm.js': '@vue/composition-api/dist/vue-composition-api.mjs'
} |
antfu
changed the title
could you elaborate on where/which file this alias is supposed to be applied? |
|
In your webpack config file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not know if this is a good solution in general, but it fixed the build for us.
After upgrading
@vue/composition-apiour own code was importingvue-composition-api.mjsinto the bundle, but@vueuse/coreviavue-demiimportedvue-composition-api.esm.js. This bundling of two different modules lead to the[vue-composition-api] must call Vue.use(VueCompositionAPI)error.