Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use createRequire to load rollup replace plugin #406

Merged
merged 3 commits into from Nov 7, 2022
Merged

fix: use createRequire to load rollup replace plugin #406

merged 3 commits into from Nov 7, 2022

Conversation

userquin
Copy link
Member

@userquin userquin commented Nov 4, 2022 •
edited

Tested with examples/vite-svelte example, without this it fails with the error on linked issue

EDIT: also tested injectManifest with vue/react/preact/solid examples

closes #405

@netlify
Copy link

netlify bot commented Nov 4, 2022 •
edited

✅ Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
🔨 Latest commit 155bf63
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/636904cebfa1980009e82a78
😎 Deploy Preview https://deploy-preview-406--vite-plugin-pwa-legacy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin userquin requested a review from antfu November 4, 2022 15:28
@userquin
Copy link
Member Author

userquin commented Nov 4, 2022 •
edited

/cc @yoyo930021 can you take a look at this (sorry to ping you directly)

@yoyo930021
Copy link
Contributor

yoyo930021 commented Nov 7, 2022 •
edited

LGTM
The only thing I'm confused about is why the @rollup/plugin-replace plugin relies in devDependencies.

@userquin userquin merged commit a94fc2a into main Nov 7, 2022
@userquin userquin deleted the fix/rollup-replace-plugin branch November 7, 2022 13:17
@userquin
Copy link
Member Author

userquin commented Nov 7, 2022

The only thing I'm confused about is why the @rollup/plugin-replace plugin relies in devDependencies.

The plugin moved to dependencies...

@mathiash98 mathiash98 mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@husayt husayt husayt approved these changes

@yoyo930021 yoyo930021 yoyo930021 approved these changes

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Dynamic require of "path" is not supported
4 participants
@userquin @yoyo930021 @husayt @antfu